Replace zend_parse_parameters() with ZEND_PARSE_PARAMETERS macros#21127
Closed
arshidkv12 wants to merge 1 commit intophp:masterfrom
Closed
Replace zend_parse_parameters() with ZEND_PARSE_PARAMETERS macros#21127arshidkv12 wants to merge 1 commit intophp:masterfrom
arshidkv12 wants to merge 1 commit intophp:masterfrom
Conversation
Member
|
nit: with your commit message, indicate which part you're applying the changes to, e.g. here |
Contributor
Author
|
Thanks for the review — noted. |
Member
|
What's the motivation to convert these to fast ZPP? |
Member
|
Like @Girgias implied, I think we should first establish which cases should be migrated to fast ZPP. ZPP increases binary size and increases cache pressure, so there's a trade-off. |
Contributor
Author
|
Can I close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.